Upgrade Core and Blaze - #931
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 92 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cmake/FindCore.cmake">
<violation number="1" location="cmake/FindCore.cmake:9">
P2: When a build dir is first configured without a sanitizer and then re-configured with JSONBINPACK_ADDRESS_SANITIZER=ON, `set(... CACHE BOOL ...)` without FORCE is a no-op because SOURCEMETA_CORE_USE_SYSTEM_ALLOCATOR is already cached as OFF, so core still links mimalloc (vendor/core/CMakeLists.txt only skips it when this flag AND the sanitizer flags are false). This is a derived value that must track the sanitizer input, so use FORCE so toggling the sanitizer in the same build dir reliably switches core to the system allocator.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| endif() | ||
|
|
||
| if(JSONBINPACK_ADDRESS_SANITIZER OR JSONBINPACK_UNDEFINED_SANITIZER) | ||
| set(SOURCEMETA_CORE_USE_SYSTEM_ALLOCATOR ON CACHE BOOL "enable the system allocator") |
There was a problem hiding this comment.
P2: When a build dir is first configured without a sanitizer and then re-configured with JSONBINPACK_ADDRESS_SANITIZER=ON, set(... CACHE BOOL ...) without FORCE is a no-op because SOURCEMETA_CORE_USE_SYSTEM_ALLOCATOR is already cached as OFF, so core still links mimalloc (vendor/core/CMakeLists.txt only skips it when this flag AND the sanitizer flags are false). This is a derived value that must track the sanitizer input, so use FORCE so toggling the sanitizer in the same build dir reliably switches core to the system allocator.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cmake/FindCore.cmake, line 9:
<comment>When a build dir is first configured without a sanitizer and then re-configured with JSONBINPACK_ADDRESS_SANITIZER=ON, `set(... CACHE BOOL ...)` without FORCE is a no-op because SOURCEMETA_CORE_USE_SYSTEM_ALLOCATOR is already cached as OFF, so core still links mimalloc (vendor/core/CMakeLists.txt only skips it when this flag AND the sanitizer flags are false). This is a derived value that must track the sanitizer input, so use FORCE so toggling the sanitizer in the same build dir reliably switches core to the system allocator.</comment>
<file context>
@@ -5,6 +5,12 @@ if(NOT Core_FOUND)
endif()
+ if(JSONBINPACK_ADDRESS_SANITIZER OR JSONBINPACK_UNDEFINED_SANITIZER)
+ set(SOURCEMETA_CORE_USE_SYSTEM_ALLOCATOR ON CACHE BOOL "enable the system allocator")
+ else()
+ set(SOURCEMETA_CORE_USE_SYSTEM_ALLOCATOR OFF CACHE BOOL "disable the system allocator")
</file context>
🤖 Augment PR SummarySummary: This PR upgrades the vendored Sourcemeta Core and Blaze revisions used by JSON BinPack. Changes:
Technical Notes: The dependency refresh includes the mimalloc source tree and related Core/Blaze build-system changes needed to propagate allocator and sanitizer behavior to downstream targets. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com